Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from logging to a file to usage of journald #22

Merged
merged 8 commits into from
Nov 5, 2013
Merged

Conversation

jfilak
Copy link
Owner

@jfilak jfilak commented Oct 30, 2013

Disable file log, enabled journald and add syslog which is disabled by default.

@ghost ghost assigned tisnik Oct 30, 2013
Jakub Filak added 8 commits November 5, 2013 14:25
Use the same message for abrt and log:

(Caught|Uncaght) exception $FQDN_TYPE in method $FQDN_METHOD

The new format misses thread name and method signature. Thread's name is
available in stack trace and method's signature is useful only for
debugging.

Length of the reason message is limited to 255 characters. If the
message exceeds that limit, algorithm tries to generate the message
according to the following formats:

(Caught|Uncaght) exception $FQDN_TYPE in method $CLASS_NAME_METHOD
(Caught|Uncaght) exception $EXCEPTION_CLASS in method $CLASS_NAME_METHOD
(Caught|Uncaght) exception $EXCEPTION_CLASS in method $METHOD

The first suitable message is used. If none of these formats generate an
acceptable message, the last format is used and the message is truncated.

Related to rhbz#1023081

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Related to rhbz#1023081

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Signed-off-by: Jakub Filak <jfilak@redhat.com>
The current implementation writes to a file in CWD.

This patch allows users to pass a path to a directory in output command
line argument. If a value of the output argument points to a directory,
the log file path is set to $output/abrt_checker_$PID.log

Related to rhbz#1023081

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Related to rhbz#1023081

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Two new command line arguments:
    syslog=(on|yes)
        - disabled by default
        - logs a stack trace to syslog with LOG_ERR level

    journald=(off|no)
        - disabled by default
        - logs a stack trace to journald with LOG_ERR level
        - the stack trace is saved in STACK_TRACE field

Related to rhbz#1023081

Signed-off-by: Jakub Filak <jfilak@redhat.com>
tisnik added a commit that referenced this pull request Nov 5, 2013
Switch from logging to a file to usage of journald
@tisnik tisnik merged commit 4b71b0b into master Nov 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants