Flask 0.10 incompatibility due to removed JSONHTTPException

[glyphobet]

With pallets/flask@4c27f7a, Flask 0.10 has removed exceptions.JSONHTTPException.

This means Flask-Restless is incompatible with Flask 0.10, since it imports JSONHTTPException.

======================================================================
ERROR: Failure: ImportError (No module named exceptions)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/nose/loader.py", line 390, in loadTestsFromName
    addr.filename, addr.module)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/nose/importer.py", line 39, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/nose/importer.py", line 86, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/Users/matt/local/src/flask-restless/flask_restless/__init__.py", line 22, in <module>
    from .manager import APIManager
  File "/Users/matt/local/src/flask-restless/flask_restless/manager.py", line 17, in <module>
    from .views import API
  File "/Users/matt/local/src/flask-restless/flask_restless/views.py", line 41, in <module>
    from .exceptions import json_abort
  File "/Users/matt/local/src/flask-restless/flask_restless/exceptions.py", line 14, in <module>
    from flask.exceptions import JSONHTTPException
ImportError: No module named exceptions

From the flask commit, it sounds like there is something wrong with handling exceptions as JSON, but @mitsuhiko doesn't really explain it further than that. A temporary fix would be to require Flask <= 0.9, but a better fix would be to understand what is wrong with JSON exceptions and find a better solution.

[glyphobet]

There are now three choices on how to fix this:

• Missing exceptions module error causing Flask-Restless to break #212 - copy over the JSON exception functionality into Flask-restless
• Flask 0.10 incompatibility due to removed JSONHTTPException  #218 - require Flask version 0.9 or lower
• Revert "Adds a wrapper around abort function to add JSON Content-Type." #228 - remove the dependency on JSON exceptions entirely

[mowliv]

Just ran into this myself - what is the plan to fix?

[glyphobet]

@mowliv If you would like to use the fork at https://github.com/goodscloud/flask-restless, go ahead, this problem is fixed there.

[jfinkels]

Hi,

Im out of the country for another week or two so I wont be merging these things for a little while. Sorry for the inconvenience.

[flexd]

Are you back yet? :-) I'd rather not run someones fork and then forget to change it back later.

[flexd]

@glyphobet What if #212 is implemented to have a working flask-restless, and then a better solution can be made later?

[glyphobet]

@flexd I fixed it in my branch with #228, because that seemed the least invasive. #212 is an alternative solution, but there would be no reason to do both. The author of Flask says #212 is a flawed design so I prefer #228.

[alexcouper]

I just opened #231 and then saw this thread and closed it. slow claps himself

For what it's worth, I too prefer #228.

[jfinkels]

I will use #228.