Allow methods to be included in response #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues of methods into JSON response structures. Also serialize SQLAlchemy mapped objects returned from an included method.
…ike include_columns)
|
This seems reasonable to me. I'll add a note in the documentation somewhere. |
jfinkels
added a commit
that referenced
this pull request
May 16, 2013
Allow methods to be included in response
jfinkels
added a commit
that referenced
this pull request
May 16, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases when the complexity of a method on a data model exceeds what is appropriate or possible using a hybrid property. I believe flask-restless should enable having this kind of logic on the model, by allowing return values of arbitrary methods to be included in the JSON response objects.
In this pull request, I have made the following changes:
Added an
include_methodsargument which allows embedding return values of methods into JSON response structures. Also, it serializes SQLAlchemy mapped objects returned from an included method.