Fixes: Fetching relationships fetches all existing resources #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic! This needs two unit tests still, one for fetching only those resources related to a resource and one for an |
|
(I just disabled the commenting by the Coveralls robot, so those won't appear anymore.) The build error seems to be an external issue, I'll restart the build to double check. Thanks for adding the tests. |
|
Thanks for finding the holes in the existing tests instead of writing new ones! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to fetch relationships via /resource//relation_name/ all existing resources of the relation type are returned. Not only those related to the resource.
I debugged this and I think that I found the potential bug.
The filter() method returns a new query object which was thrown away.
Also, the "in" operator doesn't seem to work on InstrumentedAttribute. So I changed it to use the in_() method.