Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymorphic joined #546

Closed
wants to merge 13 commits into from
Closed

Conversation

philliproso
Copy link

Add support for polymorphic joined table inheritance

jfinkels and others added 3 commits May 25, 2016 00:49
This commit adds support for fetching, creating, updating, and deleting
at endpoints corresponding to APIs created for polymorphic models
defined using single table inheritance.

This also changes the default serializer so that it supports
heterogeneous collections directly.
…nto polymorphic-models

Conflicts:
	CHANGES
	tests/helpers.py
	tests/test_polymorphism.py
@jfinkels
Copy link
Owner

Thanks for this, but I think there's a way of avoiding rewriting all of these tests by using inheritance. The test methods are all the same it seems? So in test_polymorphism, just use inheritance to vary the setUp() method so that one subclass creates a single-table inheritance test and one creates a joined table inheritance test.

Are you able to update this pull request with those changes, and then rebase on the current master so that this pull request includes just a single commit?

philliproso and others added 10 commits June 16, 2016 12:32
This commit adds support for fetching, creating, updating, and deleting
at endpoints corresponding to APIs created for polymorphic models
defined using single table inheritance.

This also changes the default serializer so that it supports
heterogeneous collections directly.

joined table inheritance

Disables PyPy3 testing on Travis.

PyPy3 is currently compliant with the Python 3.2 API, but Flask supports
only Python 3.3 or later.

Changes comments about Flask 1.0 to Flask 0.11.

Add session commit to relationship changes

Do commits after post processors

Add tests for flushing and transaction cancellation

Documents commit after postprocessors.

Updates test method docstrings.
This commit adds support for fetching, creating, updating, and deleting
at endpoints corresponding to APIs created for polymorphic models
defined using single table inheritance.

This also changes the default serializer so that it supports
heterogeneous collections directly.
This commit also adds some info about association proxies in the same
document.
Flask version 0.11 deprecates imports from `flask.ext.*` in favor import
from "flask_*" for Flask extensions. This commit changes references to,
among others, `flask.ext.restless` to `flask_restless`.
Conflicts:
	tests/test_polymorphism.py
…phic laoding techniques

Conflicts:
	tests/test_polymorphism.py
Conflicts:
	tests/test_polymorphism.py
@philliproso
Copy link
Author

@jfinkels I made the test run with an inheritance structure. Not sure if I the whole rebase and squash thing right.

@jfinkels
Copy link
Owner

jfinkels commented Jul 1, 2016

I have included your proposal in a less complicated way and in a single commit in pull request #546 so I'm closing this pull request. Thank you for your work on this!

@jfinkels jfinkels closed this Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants