Allows attributes with JSON API "reserved" names. #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfinkels
force-pushed
the
type-as-attribute
branch
from
001f686
to
dad7bd1
Compare
This was referenced Aug 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #559 and supercedes pull request #561. The
strings_to_datetimeshelper function was left over from an earlier version and was unnecessary. The checks for an attribute beingtypeorlinkswere pointless, because thestrings_to_datetimesfunction was already only looking at theattributesdictionary of a resource object.This commit includes unit tests for creating and updating a resource, and includes a changelog entry.