Fix test suites failing with simplejson. #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should use the same branch here as Flask does in its json code. I have verified the BetterJSONEncoder derivative to work with both libraries.
jfinkels
reviewed
Sep 16, 2016
There was a problem hiding this comment.
Fantastic! But I'd like to also add a line to the Travis build configuration that tests for simplejson being installed (and selected by Flask). If you can figure that out, that would be great, but if not I'll just create a new pull request that builds on this one.
Merged
|
I'm not sure what you want to achieve with this test. Can you elaborate on it a bit more? |
|
I added the test myself in pull request #587; see the Travis builds there, there is now one test for each Python version that installs simplejson before running the tests. |
|
I have merged your commit via pull request #587. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use the same branch here as Flask does in its json code. I
have verified the BetterJSONEncoder derivative to work with both
libraries.
This fixes #583.