URL encodes first, last, prev, and next links. #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfinkels
force-pushed
the
url-encode-pagination-links
branch
2 times, most recently
from
625b7f3
to
31d73a4
Compare
Previously, Flask-Restless was not URL encoding the `first`, `last`, `next`, and `prev` pagination links in the response JSON document. This commit corrects that and additionally corrects some imprecise unit tests that were not accounting for URL encoding.
jfinkels
force-pushed
the
url-encode-pagination-links
branch
from
31d73a4
to
2e5e601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Flask-Restless was not URL encoding the
first,last,next, andprevpagination links in the response JSON document. Thiscommit corrects that and additionally corrects some imprecise unit tests
that were not accounting for URL encoding.
Fixes issue #553.