-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pmf-conversion only for selected functions. #27
Allow pmf-conversion only for selected functions. #27
Conversation
More about pmf-conversions: https://gcc.gnu.org/onlinedocs/gcc/Bound-member-functions.html More about disabling compile-type warnings in GCC and Clang: https://www.fluentcpp.com/2019/08/30/how-to-disable-a-warning-in-cpp/
Is it also possible to only add this one line to #pragma GCC diagnostic ignored "-Wpmf-conversions" For example on line 3. |
If it's added in |
That is true. What about inserting the following before line 3 #pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wpmf-conversions" and this before line 9? #pragma GCC diagnostic pop I know that it is not as specific as what you suggest, but it would be a bit tidier. And I guess we can remove |
Yes, correct.
Should work. Ok, I will update the source code. |
You can see the difference in the initial suggestion (Expand "Test with Catch") and the newer version. With the new changes we kinda of hope that the developers will never include rcpCall.tcc and signature.tcc directly. |
Hmm, perhaps we should leave the As for including By the way, you can add your name to |
Looks good, thank you. |
This PR allows the usage of simpleRPC without having to explicitly provide a pmf-conversion flag during compilation.
More about pmf-conversions: https://gcc.gnu.org/onlinedocs/gcc/Bound-member-functions.html
More about disabling compile-type warnings in GCC and Clang: https://www.fluentcpp.com/2019/08/30/how-to-disable-a-warning-in-cpp/.