Fix #952 #1003
Merged
Fix #952 #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lsf37
commented
Jan 1, 2023
•
lsf37
commented
- test case for Nested Bounded Repetitions causes "Illegal Argument Exception" #952
- fix overflow in the emitter
lsf37
force-pushed
the
large_table
branch
2 times, most recently
from
9c4dd8d
to
633996f
Compare
The high/low array length is alway divisible by 2, so increasing the index by 2 is safe, but static analyzers don't know that and will complain. Comparing to length - 1 is also safe and should not lead to warnings.
lsf37
force-pushed
the
large_table
branch
2 times, most recently
from
e5770f2
to
85ca297
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The previous Emitter instances could only emit DFAs up to 2^16 states, which is large, but can be hit with small regexps that produce exponentially large DFAs. Now, when the DFA has more than 0xFFFE states, a different emitter is chosen that can represent values up to 2^32. Fixes #952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.