New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnicodeCaseless.flex.vm uses incorrect unicode escapes #1016

Closed

2 tasks done

lsf37 opened this issue Jan 4, 2023 · 1 comment · Fixed by #1025

Closed

2 tasks done

UnicodeCaseless.flex.vm uses incorrect unicode escapes #1016

lsf37 opened this issue Jan 4, 2023 · 1 comment · Fixed by #1025

Labels

testing

Member

lsf37 commented Jan 4, 2023 •

edited

The template uses \uXXXX for all code points, but this syntax is incorrect for code points > 0xFFFF (needs \U instead of \u).

investigate why this does not lead to test failures
fix it

The text was updated successfully, but these errors were encountered:

lsf37 added testing bug and removed bug labels

Member Author

lsf37 commented Jan 5, 2023

Turns out, that's what all the

  @Ignore // TODO(FIX) Character 0x10428 (=66600) should match caselessly 0x10400

were about.

lsf37 added a commit that referenced this issue


          re-instate unicode caseless matching tests

2d74928

See also #1016

lsf37 added a commit that referenced this issue


          fix unicodedatatest caseless lexers, reduce warnings

66c166e

Fixes #1016

lsf37 added a commit that referenced this issue


          fix unicodedatatest caseless lexers, reduce warnings

74ce1e2

Fixes #1016

lsf37 added a commit that referenced this issue


          re-instate unicode caseless matching tests

c2e7dc3

See also #1016

lsf37 linked a pull request

that will close this issue

Fix unicode caseless tests #1025

Merged

lsf37 closed this as completed in

0b9c3b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment