New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] OS/2 Java 1.1.8 Issues [sf#71] #73

Closed
lsf37 opened this Issue Feb 15, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@lsf37
Member

lsf37 commented Feb 15, 2015

Reported by bernd_hohmann on 2004-11-12 23:57 UTC
Two minor compatibility issues:

  1. Class ErrorMessages, declaration part
    It's dangerous to create an instance of RessourceBundle
    here because the IBM implementation reads the ressource
    file asap which causes an ExceptionInInitializerError
    in the class and it is hard to track this down.

Suggested change in declaration part:
private static ResourceBundle RESOURCE_BUNDLE = null;

Suggested change in public static String
get(ErrorMessages msg)

try {
if (RESOURCE_BUNDLE == null) {
RESOURCE_BUNDLE =
ResourceBundle.getBundle("JFlex.Messages");
}
return RESOURCE_BUNDLE.getString(msg.key);
} catch (MissingResourceException e) {
return '!' + msg.key + '!';
}

Or a warning to System.out if .getBundle(...) throwed a
MissingResourceException

  1. Skeleton#readDefault()
    suggested Change:

//ClassLoader l = Skeleton.class.getClassLoader();
//URL url = l.getResource("JFlex/skeleton.default");
URL url =
ClassLoader.getSystemResource("JFlex/skeleton.default");

At least for me, the first variant returns NULL as
classloader, the second variant works because jflex.jar
is in the classpath

@lsf37 lsf37 changed the title from OS/2 Java 1.1.8 Issues to [Bug] OS/2 Java 1.1.8 Issues [sf#71] Feb 15, 2015

@lsf37 lsf37 added this to the Java/JIT bug milestone Feb 15, 2015

@lsf37 lsf37 closed this Feb 15, 2015

@lsf37

This comment has been minimized.

Show comment
Hide comment
@lsf37

lsf37 Feb 15, 2015

Member

Commented by lsf37 on 2004-12-19 09:03 UTC
Logged In: YES
user_id=93534

Thanks for the report and fixes. I've included the first and a
variation of the second into the repository version. Could you check
if they work for you?

Gerwin

Member

lsf37 commented Feb 15, 2015

Commented by lsf37 on 2004-12-19 09:03 UTC
Logged In: YES
user_id=93534

Thanks for the report and fixes. I've included the first and a
variation of the second into the repository version. Could you check
if they work for you?

Gerwin

@lsf37

This comment has been minimized.

Show comment
Hide comment
@lsf37

lsf37 Feb 15, 2015

Member

Updated by lsf37 on 2004-12-19 09:03 UTC

  • milestone: 104413 --> Java/JIT bug
  • priority: 5 --> 3
  • status: open --> open-fixed
Member

lsf37 commented Feb 15, 2015

Updated by lsf37 on 2004-12-19 09:03 UTC

  • milestone: 104413 --> Java/JIT bug
  • priority: 5 --> 3
  • status: open --> open-fixed
@lsf37

This comment has been minimized.

Show comment
Hide comment
@lsf37

lsf37 Feb 15, 2015

Member

Updated by lsf37 on 2008-05-27 11:46 UTC

  • status: open-fixed --> closed
Member

lsf37 commented Feb 15, 2015

Updated by lsf37 on 2008-05-27 11:46 UTC

  • status: open-fixed --> closed

@lsf37 lsf37 added the bug label Feb 17, 2015

@lsf37 lsf37 removed this from the Java/JIT bug milestone Feb 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment