-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use elm-json from environment ($PATH?) instead of downloading it. #157
Comments
Hey @jumper149, We have had a number of issues with using
Yes.
That's all I can think of right now. |
I am not sure, if exchanging
That shouldn't be a problem. Invocations of the
It would be nice to have a flag to turn off that feature (at least for my usecase). Overall I think it's good to isolate side-effects from the rest of a program, but I guess I don't have to preach about purity to Elm users.
Just like (1.) this should be fine. |
We do a fairly horrible thing where we patch It's not that much fun, but we probably should upstream that to nixpkgs. |
@zwilias Well, it's a pragmatic fix to the issue at hand. Are you running Upstreaming to nixpkgs is always nice, but if there was a fix for I haven't looked into the source of I am not sure if I can find the time to do it anytime soon, but I'll keep it mind. @jfmengels Even if you decide to use Edit: Or you could make it a build-time dependency instead of a runtime dependency. That way you would also avoid the problem. |
Now there’s one more potential solution: Replacing |
Firstly, this issue should be in node-elm-review (oh, it is jfmengels/node-elm-review#81). |
Yes, this was solved in jfmengels/node-elm-review#81 which has been released in elm-review v2.11 onwards. |
I would like to run
elm-review
in a nix expression, butelm-review
will try to downloadelm-json
, which is impure and therefore not allowed from within nix.Could
elm-review
use theelm-json
that is already available in the environment?On another note. Are there other cases where
elm-review
wants download anything?The text was updated successfully, but these errors were encountered: