Fix crash around ignoredDirs/ignoredFiles in result-cache

jfmengels · May 4, 2024 · 20bd897 · 20bd897
1 parent b3f6d15
commit 20bd897
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/lib/elm-app-worker.js b/lib/elm-app-worker.js
@@ -18,6 +18,8 @@ const app = elmModule.Elm.Elm.Review.Main.init({
 
 const loadCachePromise = ResultCache.load(
   workerData.flags,
+  workerData.flags.ignoredDirs,
+  workerData.flags.ignoredFiles,
   workerData.flags.resultCacheFolder
 );
 

diff --git a/lib/main.js b/lib/main.js
@@ -74,7 +74,12 @@ async function runElmReview() {
       Runner.initializeApp(options, elmModulePath, reviewElmJson, appHash)
     ),
 
-    ResultCache.load(options, options.resultCachePath(appHash))
+    ResultCache.load(
+      options,
+      options.ignoredDirs(),
+      options.ignoredFiles(),
+      options.resultCachePath(appHash)
+    )
   ]);
 
   const success = await Runner.runReview(options, app);

diff --git a/lib/result-cache.js b/lib/result-cache.js
@@ -23,16 +23,18 @@ const promisesToResolve = new Map();
 /**
  * Load cache results.
  * @param {Options} options
+ * @param {string[]} ignoredDirs
+ * @param {string[]} ignoredFiles
  * @param {Path} cacheFolder
  * @returns {Promise<void>}
  */
-async function load(options, cacheFolder) {
+async function load(options, ignoredDirs, ignoredFiles, cacheFolder) {
   // TODO Make caching work for all of these
   if (
     options.debug ||
     options.directoriesToAnalyze.length > 0 ||
-    options.ignoredDirs().length > 0 ||
-    options.ignoredFiles().length > 0
+    ignoredDirs.length > 0 ||
+    ignoredFiles.length > 0
   ) {
     // TODO Breaking change: When we drop support for Node.js v10, use `globalThis` everywhere instead of `global`
     global.loadResultFromCache = () => null;