Fix crash when caching results in watch mode

jfmengels · Mar 16, 2024 · 956b2cc · 956b2cc
1 parent 0c82b00
commit 956b2cc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## [Unreleased]
 
+- Fixed a crash when running in watch mode related to not being able to fetch cache results.
 - Improve the error message when failing to update suppression files.
 
 ## [2.11.0] - 2024-03-15

diff --git a/lib/main.js b/lib/main.js
@@ -73,7 +73,7 @@ async function runElmReview() {
       Runner.initializeApp(options, elmModulePath, reviewElmJson, appHash)
     ),
 
-    ResultCache.load(options, appHash)
+    ResultCache.load(options, options.resultCachePath(appHash))
   ]);
 
   const success = await Runner.runReview(options, app);

diff --git a/lib/result-cache.js b/lib/result-cache.js
@@ -13,7 +13,7 @@ let worker = null;
 const resultCache = new Map();
 const promisesToResolve = new Map();
 
-async function load(options, appHash) {
+async function load(options, cacheFolder) {
   // TODO Make caching work for all of these
   if (
     options.debug ||
@@ -47,7 +47,6 @@ async function load(options, appHash) {
   }
 
   resultCache.clear();
-  const cacheFolder = options.resultCachePath(appHash);
   global.elmJsonReplacer = ResultCacheJson.replacer;
 
   global.loadResultFromCache = (ruleName, ruleId) => {