corrections after refactoring #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ANemcov
reviewed
Dec 2, 2019
| @@ -112,10 +113,17 @@ def receive_issue_reply_with_helpdesk(issue_id, from_journal=nil) | |||
| return last_journal | |||
| end | |||
|
|
|||
| def custom_field_value(issue,name) | |||
| # differentiate between project field and issue field | |||
| def custom_field_value(issue,name,isproject_field = true) | |||
There was a problem hiding this comment.
That is over engineering :)
CustomField_ID has sequential numbering. And each field assigned either to project or to issue.
There was a problem hiding this comment.
Since it's not used elsewhere it's over engineered, you're right. And what I've learned by writing some ruby, it's not nice ruby style, too ;).
I just did not want to redo the cleaning work that was done before as I like easy to read code and it was already in an own function.
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO differentiation between project field and issue field is needed here.
These are my first steps with RoR and redmine plugins, so maybe it's an inelegant approach.
I haven't found any naming conventions or guidelines for redmine(-plugins ) so please correct my code if it's bad!