Call to getHour() in compare is wasteful.

jfree · Jan 8, 2023 · 995fc69 · 995fc69
1 parent b3e20e2
commit 995fc69
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/main/java/org/jfree/data/time/Minute.java b/src/main/java/org/jfree/data/time/Minute.java
@@ -420,9 +420,12 @@ public int compareTo(Object o1) {
         // -------------------------------------------
         if (o1 instanceof Minute) {
             Minute m = (Minute) o1;
-            result = getHour().compareTo(m.getHour());
+            result = this.day.compareTo(m.day);
             if (result == 0) {
-                result = this.minute - m.getMinute();
+                result = this.hour - m.hour;
+                if (result == 0) {
+                    result = this.minute - m.getMinute();
+                }
             }
         }
 

diff --git a/src/test/java/org/jfree/data/time/MinuteTest.java b/src/test/java/org/jfree/data/time/MinuteTest.java
@@ -86,6 +86,9 @@ public void comparison() {
         Minute m1 = new Minute(30, 6, 10, 8, 2021);
         Minute m2 = new Minute(30, 6, 11, 8, 2021);
         assertNotEquals(m1, m2);
+        assertEquals(-1, m1.compareTo(m2));
+        assertEquals(1, m2.compareTo(m1));
+        assertEquals(0, m1.compareTo(m1));
     }
 
     /**