Allow to change modifiers for panning and zooming #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some applications, the defaults were inconvenient. For example, sometimes it is better to pan by default because users need it more often than zoom. Also, switch to getModifiersEx() instead of getModifiers(). Compatibility warning: panMask is protected, so whatever subclases expected to find old-style modifiers there (getModifiers()) will fail to do so (because it is now in getModifiersEx() language).
stachenov
force-pushed
the
zoom-pan-modifiers
branch
from
4e4af2e
to
ed36547
Compare
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some applications, the defaults were inconvenient. For example, sometimes it is better to pan by default because users need it more often than zoom. In my application, I had to alter events with reflection to get the behavior I wanted, which is ugly, to say the least.
Also, switch to
getModifiersEx()instead ofgetModifiers()becausegetModifiers()is long deprecated.Compatibility warning:
panMaskis protected, so whatever subclases expected to find old-style modifiers there (getModifiers()) will fail to do so (because it is now in getModifiersEx() language). Perhaps it was a wrong decision to switch to getModifiers(), but doing otherwise would force users to use deprecated constants. Anyway, the only thing possible subclasses could do withpanMaskis to change pan modifiers, say, from Ctrl to Shift, but not to zero because they would conflict with zoom then.