Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ArtifactoryPluginConvention to ArtifactoryPluginExtension #73

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Goooler
Copy link

@Goooler Goooler commented Oct 2, 2023

Better alignment with the migration of convention usages.

Follow up #72.

  • All tests passed. If this feature is not already covered by the tests, I added new
    tests.

Better alignment with the migration of convention usages.

Follow up 1e30e99.
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Goooler
Copy link
Author

Goooler commented Oct 2, 2023

I have read the CLA Document and I hereby sign the CLA

@yahavi
Copy link
Member

yahavi commented Oct 3, 2023

Hey @Goooler and thanks for your contribution!
The renaming here does create a breaking change for Kotlin users, and it's important to note that we didn't make this change with that intention in mind. Do you think there's a genuine reason to justify this modification?

@Goooler
Copy link
Author

Goooler commented Oct 3, 2023

I believe we should follow the Gradle guidance to use a standard extension(including honoring the standard extension name), we can note this point in changelog and recommend users to use artifactory block to configure properties like the Groovy did.

@yahavi yahavi added the safe to test Approve running tests on a pull request label Nov 21, 2023
@github-actions github-actions bot removed the safe to test Approve running tests on a pull request label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants