Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Dependency Tree - Yarn V1 #172

Merged
merged 51 commits into from
Aug 3, 2023
Merged

Build Dependency Tree - Yarn V1 #172

merged 51 commits into from
Aug 3, 2023

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Jul 26, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Introduced compatibility for creating dependency trees in Yarn projects prior to version 2.0.0.
Building a dependency tree is now supported across all Yarn versions.
This update also includes new tests and test cases + additional checks in existing tests

@github-actions
Copy link

github-actions bot commented Jul 26, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@eranturgeman eranturgeman marked this pull request as draft July 26, 2023 08:59
@eranturgeman eranturgeman changed the title Yarn V1 Audit Build Dependency Tree - Yarn V1 Jul 26, 2023
@eranturgeman
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@eranturgeman
fixed static analysis issues
3dbeb76
@eranturgeman
updated path for tested project example
02956c5
@eranturgeman
TestGenerateBuildInfoForYarnProject : updated path for tested project…
1272b60 
… and fixed test according to new package.json for this project
@eranturgeman
TestCollectDepsForYarnProjectWithTraverse, TestCollectDepsForYarnProj…
8096e3c 
…ectWithErrorInTraverse, TestBuildYarnProjectWithArgs: updated path for tested project and fixed test according to new package.json for this project
sverdlov93
sverdlov93 reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@sverdlov93 sverdlov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not reviewed all PR yet

build/utils/yarn.go Outdated Show resolved Hide resolved
build/utils/npm.go Show resolved Hide resolved
build/utils/npm.go Show resolved Hide resolved
build/utils/yarn.go Show resolved Hide resolved
build/utils/yarn.go Show resolved Hide resolved
build/utils/yarn.go Outdated Show resolved Hide resolved
eranturgeman
eranturgeman commented Jul 27, 2023
View reviewed changes
build/yarn_test.go Outdated Show resolved Hide resolved
sverdlov93
sverdlov93 reviewed Jul 27, 2023
View reviewed changes
build/utils/yarn_test.go Outdated Show resolved Hide resolved
build/utils/yarn_test.go Outdated Show resolved Hide resolved
build/utils/yarn_test.go Outdated Show resolved Hide resolved
build/utils/yarn_test.go Outdated Show resolved Hide resolved
build/utils/yarn_test.go Outdated Show resolved Hide resolved
build/utils/yarn_test.go Outdated Show resolved Hide resolved
build/utils/yarn_test.go Outdated Show resolved Hide resolved
build/utils/yarn_test.go Outdated Show resolved Hide resolved
build/utils/yarn_test.go Outdated Show resolved Hide resolved
build/utils/yarn_test.go Outdated Show resolved Hide resolved
sverdlov93
sverdlov93 reviewed Aug 2, 2023
View reviewed changes
build/utils/yarn.go Outdated Show resolved Hide resolved
build/utils/yarn.go Outdated Show resolved Hide resolved
sverdlov93
sverdlov93 reviewed Aug 2, 2023
View reviewed changes
build/utils/yarn.go Outdated Show resolved Hide resolved
build/utils/yarn.go Outdated Show resolved Hide resolved
build/utils/yarn.go Outdated Show resolved Hide resolved
build/utils/yarn.go Outdated Show resolved Hide resolved
build/utils/yarn.go Outdated Show resolved Hide resolved
build/utils/yarn.go Outdated Show resolved Hide resolved
build/utils/yarn.go Show resolved Hide resolved
build/utils/yarn_test.go Outdated Show resolved Hide resolved
build/utils/yarn_test.go Outdated Show resolved Hide resolved
@eranturgeman eranturgeman added the new feature Automatically generated release notes label Aug 3, 2023
This was referenced Aug 3, 2023
Merged
Merged
@eranturgeman eranturgeman temporarily deployed to frogbot August 3, 2023 10:03 — with GitHub Actions Inactive
@eranturgeman eranturgeman temporarily deployed to frogbot August 3, 2023 12:14 — with GitHub Actions Inactive
@eranturgeman eranturgeman temporarily deployed to frogbot August 3, 2023 12:19 — with GitHub Actions Inactive
@eranturgeman eranturgeman temporarily deployed to frogbot August 3, 2023 12:57 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

@eranturgeman eranturgeman merged commit 8230595 into jfrog:dev Aug 3, 2023
13 checks passed
@eyalbe4 eyalbe4 removed the new feature Automatically generated release notes label Aug 3, 2023
@grinish21 grinish21 mentioned this pull request Aug 14, 2023
Closed
grinish21 added a commit to grinish21/build-info-go that referenced this pull request Aug 14, 2023
@grinish21
fix: adds support for all yarn version by removing the minimun versio…
90611f7 
…n check.

PR jfrog#172 adds supports for yarn V1 but fails to actually enable it when building via the API's
@grinish21 grinish21 mentioned this pull request Aug 14, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eranturgeman @sverdlov93 @eyalbe4