Add https_proxy and no_proxy configurations to the Maven repository resolution #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
yahavi
requested changes
Apr 27, 2023
There was a problem hiding this comment.
Please consider the suggested changes. I'd like to review it again before merging.
Also:
- Run reformat on all files before submitting a PR
- I added some coding-style comments that may be applied to other added code locations
- Avoid using "Boolean" unless it is really needed
...xtractor/src/main/java/org/jfrog/build/extractor/clientConfiguration/client/ManagerBase.java
Outdated
Show resolved
Hide resolved
build-info-client/src/main/java/org/jfrog/build/client/JFrogHttpClient.java
Outdated
Show resolved
Hide resolved
build-info-client/src/main/java/org/jfrog/build/client/PreemptiveHttpClientBuilder.java
Show resolved
Hide resolved
.../main/java/org/jfrog/build/extractor/clientConfiguration/ArtifactoryClientConfiguration.java
Outdated
Show resolved
Hide resolved
.../main/java/org/jfrog/build/extractor/clientConfiguration/ArtifactoryClientConfiguration.java
Outdated
Show resolved
Hide resolved
Comment on lines
11
to
12
| String HTTPS = "https"; | ||
| String NO_PROXY_DOMAIN = "noProxyDomain"; |
There was a problem hiding this comment.
Would that work if we have both HTTP_PROXY and HTTPS_PROXY environment variables in the JFrog CLI?
...maven3/src/test/java/org/jfrog/build/extractor/maven/resolver/ArtifactoryResolutionTest.java
Outdated
Show resolved
Hide resolved
...maven3/src/test/java/org/jfrog/build/extractor/maven/resolver/ArtifactoryResolutionTest.java
Outdated
Show resolved
Hide resolved
...maven3/src/test/java/org/jfrog/build/extractor/maven/resolver/ArtifactoryResolutionTest.java
Outdated
Show resolved
Hide resolved
...maven3/src/test/java/org/jfrog/build/extractor/maven/resolver/ArtifactoryResolutionTest.java
Outdated
Show resolved
Hide resolved
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
This was referenced May 1, 2023
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
github-actions
bot
removed
the
safe to test
…s. Use proxy selector for maven deployment
yahavi
requested changes
May 9, 2023
| proxy.setPort(resolutionHelper.getProxyPort()); | ||
| proxy.setUserName(resolutionHelper.getProxyUsername()); | ||
| proxy.setPassword(resolutionHelper.getProxyPassword()); | ||
| ArtifactoryPluginResolution artifactoryResolution = new ArtifactoryPluginResolution(resolutionHelper.getRepoReleaseUrl(), resolutionHelper.getRepoSnapshotUrl(), resolutionHelper.getRepoUsername(), resolutionHelper.getRepoPassword(), proxySelector, new NullPlexusLog()); |
There was a problem hiding this comment.
Providing a null logger may hide some valuable information. Can we use a regular log or use an adapter to our logger?
There was a problem hiding this comment.
RemovedNullPlexusLog() in flavor of resolutionHelper.getLogger()
build-info-extractor/src/main/java/org/jfrog/build/extractor/ProxySelector.java
Outdated
Show resolved
Hide resolved
Or-Geva
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, HTTP proxy functions will be extended to support HTTPS-proxy and no-proxy domains in the maven repository resolution functions.
Related to: