Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip collecting pom if not exists #770

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Skip collecting pom if not exists #770

merged 1 commit into from
Dec 11, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Dec 11, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

In Maven builds, the absence of a pom.xml file in the working directory might result in the following error:

java.lang.IllegalArgumentException: File not found: null
    at org.jfrog.build.extractor.clientConfiguration.deploy.DeployDetails$Builder.build (DeployDetails.java:154)
    at org.jfrog.build.extractor.maven.BuildInfoRecorder.addDeployableArtifact (BuildInfoRecorder.java:577)
    at org.jfrog.build.extractor.maven.BuildInfoRecorder.addPomArtifact (BuildInfoRecorder.java:540)

To replicate this problem, use the Maven deploy plugin to deploy a file from a directory lacking pom.xml. For instance:

jf mvn org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy-file -Dfile=README -Durl=https://acme.jfrog.io/artifactory/default-maven-local/ -DgroupId=groupId -DartifactId=artifactId -Dversion=1.0.0 -Dpackaging=jar -DrepositoryId=artifactory -s settings.xml

@yahavi yahavi added the bug Create a report to help us improve label Dec 11, 2023
@yahavi yahavi requested a review from eyalbe4 December 11, 2023 09:15
@yahavi yahavi self-assigned this Dec 11, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Dec 11, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 11, 2023
Copy link

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


@yahavi yahavi changed the title Skip collecting pom if not exist Skip collecting pom if not exists Dec 11, 2023
@yahavi yahavi merged commit 2b9ddae into jfrog:master Dec 11, 2023
41 checks passed
@yahavi yahavi deleted the pom-null branch December 11, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Create a report to help us improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants