Client configuration should prefer system properties #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahavi
added
the
safe to test
github-actions
bot
removed
the
safe to test
yahavi
added
the
safe to test
github-actions
bot
removed
the
safe to test
Or-Geva
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix jfrog/jfrog-cli#2373
The setup for the client should prioritize Java system properties over the default properties set by the JFrog CLI. Take this command, for instance, where the JFrog CLI specifies
artifactory.publish.artifacts=true, but a conflicting false value is set by a system property:In this case, the system property should take precedence over the default value from the JFrog CLI.