Fix running executables with spaces in their paths in Windows #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th environment variable and execute it using its name. We do that to avoid passing an executable path that contains spaces, which cause parsing issues in Windows CMD.
asafgabai
added
bug
github-actions
bot
removed
the
safe to test
…th environment variable and execute it using its name. We do that to avoid passing an executable path that contains spaces, which cause parsing issues in Windows CMD.
asafgabai
added
the
safe to test
github-actions
bot
removed
the
safe to test
Or-Geva
requested changes
Jan 14, 2024
build-info-extractor/src/main/java/org/jfrog/build/extractor/executor/CommandExecutor.java
Outdated
Show resolved
Hide resolved
asafgabai
added
the
safe to test
github-actions
bot
removed
the
safe to test
asafgabai
added
the
safe to test
github-actions
bot
removed
the
safe to test
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing a command on Windows, add its directory path to the Path environment variable and execute it using its name. We do that to avoid passing an executable path that contains spaces, which causes parsing issues in Windows CMD.