Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encryption keys aren't passed in Linux Jenkins agents #779

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Encryption keys aren't passed in Linux Jenkins agents #779

merged 1 commit into from
Jan 11, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Jan 11, 2024 •
edited

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Instead of setting the buildInfoConfig.propertiesFileKey and buildInfoConfig.propertiesFileKeyIvy environment variables, set the following environment variables:
PROPERTIES_FILE_KEY and PROPERTIES_FILE_KEY_IV.

@yahavi yahavi added the bug Create a report to help us improve label Jan 11, 2024
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jan 11, 2024
@yahavi yahavi self-assigned this Jan 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 11, 2024
@yahavi yahavi changed the title Encryption keys don't passed in linux Jenkins agents Encryption keys aren't passed in Linux Jenkins agents Jan 11, 2024
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jan 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 11, 2024
@yahavi yahavi requested a review from Or-Geva January 11, 2024 12:59
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@yahavi yahavi mentioned this pull request Jan 11, 2024
Merged
3 tasks
Or-Geva
Or-Geva approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@Or-Geva Or-Geva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yahavi yahavi merged commit 9fb0ab8 into jfrog:master Jan 11, 2024
30 checks passed
@yahavi yahavi deleted the enc-linux branch January 11, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Or-Geva Or-Geva Or-Geva approved these changes

Assignees

@yahavi yahavi

Labels
bug Create a report to help us improve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yahavi @Or-Geva