Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove commons-collections and add Multimaps #795

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Remove commons-collections and add Multimaps #795

merged 1 commit into from
Jun 17, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Jun 16, 2024

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.

@yahavi yahavi added the improvement Automatically generated release notes label Jun 16, 2024
@yahavi yahavi self-assigned this Jun 16, 2024
@yahavi yahavi requested a review from eyalbe4 June 16, 2024 12:57
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 16, 2024
eyalbe4
eyalbe4 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yahavi,
I approved this PR.
Are you sure however that copying the code of those collections is the only way to overcome Jenkins' class filtering?

@yahavi
Copy link
Member Author

yahavi commented Jun 17, 2024 •
edited
Loading

This isn't a copy; it's my own implementation.
Yes, I managed to overcome the class filtering only with my implementation.

@yahavi yahavi merged commit 90ef814 into jfrog:master Jun 17, 2024
40 of 41 checks passed
@yahavi yahavi deleted the multimap branch June 17, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Assignees

@yahavi yahavi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yahavi @eyalbe4