-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable using environment variables along with frogbot-config.yml #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerzi
added
safe to test
Approve running integration tests on a pull request
improvement
Automatically generated release notes
labels
May 30, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
May 30, 2023
omerzi
added
the
safe to test
Approve running integration tests on a pull request
label
May 30, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
May 30, 2023
omerzi
added
the
safe to test
Approve running integration tests on a pull request
label
May 30, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
May 30, 2023
omerzi
added
the
safe to test
Approve running integration tests on a pull request
label
May 30, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
May 30, 2023
omerzi
added
the
safe to test
Approve running integration tests on a pull request
label
May 31, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
May 31, 2023
omerzi
added
the
safe to test
Approve running integration tests on a pull request
label
May 31, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
May 31, 2023
omerzi
added
the
safe to test
Approve running integration tests on a pull request
label
Jun 13, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Jun 13, 2023
omerzi
added
the
safe to test
Approve running integration tests on a pull request
label
Jun 14, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Jun 14, 2023
omerzi
added
the
safe to test
Approve running integration tests on a pull request
label
Jun 14, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Jun 14, 2023
omerzi
added
the
safe to test
Approve running integration tests on a pull request
label
Jun 14, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Jun 14, 2023
eyalbe4
requested changes
Jun 20, 2023
omerzi
added
the
safe to test
Approve running integration tests on a pull request
label
Jun 20, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request brings two significant enhancements to Frogbot's configuration management:
Prioritizing frogbot-config.yml over environment variables: If a field is configured both in the frogbot-config.yml file and as an environment variable, the frogbot-config.yml would take precedence. This ensures that any configuration settings specified in the frogbot-config.yml file will override the corresponding values set as environment variables, providing users with more control and consistency in their configuration management for each repository.
This pull request enhances Frogbot's configuration by utilizing environment variables as the default settings for all repositories, while providing the ability to override these defaults through the frogbot-config.yml file for customized configurations.