Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable using environment variables along with frogbot-config.yml #352

Merged
merged 21 commits into from
Jun 20, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented May 30, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This pull request brings two significant enhancements to Frogbot's configuration management:

  1. Prioritizing frogbot-config.yml over environment variables: If a field is configured both in the frogbot-config.yml file and as an environment variable, the frogbot-config.yml would take precedence. This ensures that any configuration settings specified in the frogbot-config.yml file will override the corresponding values set as environment variables, providing users with more control and consistency in their configuration management for each repository.

  2. This pull request enhances Frogbot's configuration by utilizing environment variables as the default settings for all repositories, while providing the ability to override these defaults through the frogbot-config.yml file for customized configurations.

@omerzi omerzi added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels May 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 30, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label May 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 30, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label May 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 30, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label May 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 30, 2023
@omerzi omerzi marked this pull request as draft May 30, 2023 14:50
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label May 31, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 31, 2023
@omerzi omerzi marked this pull request as ready for review May 31, 2023 07:50
@omerzi omerzi requested a review from eyalbe4 May 31, 2023 07:50
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label May 31, 2023
@omerzi omerzi marked this pull request as draft May 31, 2023 08:04
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 31, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jun 13, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 13, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jun 14, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 14, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jun 14, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 14, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jun 14, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 14, 2023
@github-actions
Copy link
Contributor

What is Frogbot?

commands/utils/params.go Show resolved Hide resolved
commands/utils/params.go Outdated Show resolved Hide resolved
commands/utils/params.go Outdated Show resolved Hide resolved
commands/utils/params.go Show resolved Hide resolved
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jun 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 20, 2023
@omerzi omerzi merged commit dbf09b4 into jfrog:dev Jun 20, 2023
10 of 11 checks passed
@github-actions
Copy link
Contributor

What is Frogbot?

@omerzi omerzi deleted the merge-config-and-env branch July 23, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants