Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old comments in pull requests #400

Merged
merged 12 commits into from
Jul 30, 2023
Merged

Remove old comments in pull requests #400

merged 12 commits into from
Jul 30, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Jul 25, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Depends on:
jfrog/froggit-go#99

  • Before adding a new pull request comment, Frogbot will remove older ones.

@omerzi omerzi added the improvement Automatically generated release notes label Jul 25, 2023
This was referenced Jul 25, 2023
Closed
Closed
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 25, 2023
@omerzi omerzi requested a review from sverdlov93 July 25, 2023 13:16
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 25, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 25, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 25, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 27, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 27, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 27, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 27, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 27, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 27, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 27, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 27, 2023
sverdlov93
sverdlov93 reviewed Jul 27, 2023
View reviewed changes
commands/scanpullrequest_test.go Show resolved Hide resolved
commands/utils/utils.go Show resolved Hide resolved
commands/scanpullrequest.go Outdated Show resolved Hide resolved
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 27, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 27, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 27, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 27, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 27, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 27, 2023
@github-actions
Copy link
Contributor

@omerzi omerzi merged commit 0720844 into jfrog:dev Jul 30, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 left review comments

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@omerzi @sverdlov93