Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create fix pull request - added support for Yarn1 #423

Merged
merged 36 commits into from
Aug 15, 2023
Merged

Create fix pull request - added support for Yarn1 #423

merged 36 commits into from
Aug 15, 2023

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Aug 8, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

We have added support for 'create-fix-pull-request' in Yarn versions earlier than 2.0.0!
'create-fix-pull-request' functionality is now compatible with all Yarn versions

NOTICE: 'create-fix-pull-request' for Yarn 1 will NOT update node_modules according to suggested fixes (even if node_modules exist in the github repo). Make sure to run 'yarn install' after accepting a suggested fix

dependes on: jfrog/jfrog-cli-core#892

@eranturgeman eranturgeman temporarily deployed to frogbot August 8, 2023 11:00 — with GitHub Actions Inactive
@eranturgeman eranturgeman temporarily deployed to frogbot August 9, 2023 13:18 — with GitHub Actions Inactive
@eranturgeman eranturgeman temporarily deployed to frogbot August 9, 2023 13:37 — with GitHub Actions Inactive
@eranturgeman eranturgeman temporarily deployed to frogbot August 9, 2023 14:01 — with GitHub Actions Inactive
@eranturgeman eranturgeman added new feature Automatically generated release notes safe to test Approve running integration tests on a pull request labels Aug 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot August 9, 2023 14:05 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot August 9, 2023 15:16 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot August 9, 2023 15:55 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot August 14, 2023 14:35 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 14, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 14, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot August 15, 2023 06:29 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot August 15, 2023 09:27 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot August 15, 2023 10:22 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot August 15, 2023 11:41 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 15, 2023
@github-actions
Copy link
Contributor

@eranturgeman eranturgeman merged commit 55c9196 into jfrog:dev Aug 15, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 approved these changes

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eranturgeman @sverdlov93