-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance parsing of the maven-dep-tree output #599
Merged
omerzi
merged 17 commits into
jfrog:dev
from
omerzi:parse-only-json-in-mvn-dep-tree-fix
Dec 14, 2023
Merged
Enhance parsing of the maven-dep-tree output #599
omerzi
merged 17 commits into
jfrog:dev
from
omerzi:parse-only-json-in-mvn-dep-tree-fix
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
omerzi
commented
Dec 6, 2023
•
edited
Loading
edited
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
- Enhance parsing of the maven-dep-tree output ignoring the possible existence of a maven.config file.
- Regarding: scan-repository - invalid character '\x1b' looking for beginning of value #587 (comment)
- Based on: Enhance parsing of the maven-dep-tree output jfrog-cli-core#1062
omerzi
added
safe to test
Approve running integration tests on a pull request
improvement
Automatically generated release notes
labels
Dec 6, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 6, 2023
…fix' into parse-only-json-in-mvn-dep-tree-fix
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 6, 2023
eyalbe4
requested changes
Dec 6, 2023
eyalbe4
requested changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice that some of the tests on this PR are failing.
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 6, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 6, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 7, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 7, 2023
…fix' into parse-only-json-in-mvn-dep-tree-fix
…vn-dep-tree-fix # Conflicts: # go.sum
omerzi
added
the
safe to test
Approve running integration tests on a pull request
label
Dec 13, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 13, 2023
…vn-dep-tree-fix # Conflicts: # go.sum
…fix' into parse-only-json-in-mvn-dep-tree-fix
omerzi
added
the
safe to test
Approve running integration tests on a pull request
label
Dec 13, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 13, 2023
omerzi
added
the
safe to test
Approve running integration tests on a pull request
label
Dec 13, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 13, 2023
omerzi
added
the
safe to test
Approve running integration tests on a pull request
label
Dec 13, 2023
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 13, 2023
yahavi
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.