Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance parsing of the maven-dep-tree output #599

Merged
merged 17 commits into from
Dec 14, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Dec 6, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@omerzi omerzi added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Dec 6, 2023
@omerzi omerzi requested a review from yahavi December 6, 2023 08:45
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 6, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Dec 6, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 6, 2023
utils/utils.go Outdated Show resolved Hide resolved
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that some of the tests on this PR are failing.

@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Dec 6, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 6, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Dec 6, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 6, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Dec 7, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 7, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Dec 7, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 7, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Dec 13, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 13, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Dec 13, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 13, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Dec 13, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 13, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Dec 13, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 13, 2023
@omerzi omerzi merged commit 6cdc78e into jfrog:dev Dec 14, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants