Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding error logs report to Coralogix #673

Merged
merged 8 commits into from
Apr 10, 2024
Merged

Adding error logs report to Coralogix #673

merged 8 commits into from
Apr 10, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Apr 2, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

Introducing enhanced functionalities for Frogbot.
In the event of an error occurring during Frogbot's execution, a report is automatically dispatched to Coralogix, contingent upon the Xsc service being enabled.

depends on: jfrog/jfrog-cli-security#49

@eranturgeman eranturgeman marked this pull request as draft April 2, 2024 06:43
@eranturgeman
Merge branch 'dev' of https://github.com/jfrog/frogbot into frogbot-e…
70bd85d 
…rror-logs-report

# Conflicts:
#	go.mod
#	go.sum
@eranturgeman eranturgeman marked this pull request as ready for review April 8, 2024 12:36
@eranturgeman eranturgeman changed the title Log error event Adding error logs report to Coralogix Apr 8, 2024
@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Apr 8, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 8, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 8, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 8, 2024
attiasas
attiasas reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

@eranturgeman eranturgeman merged commit 1da24db into jfrog:dev Apr 10, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas left review comments

@hadarshjfrog hadarshjfrog Awaiting requested review from hadarshjfrog

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eranturgeman @attiasas