-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing OIDC integration #696
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sverdlov93
reviewed
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing OpenID-Connect authorization protocol!
This Feature allows the user to get an access token to be used by Frogbot without saving it as a secret in the repository.
For detailed explanation please refer to our documentation: https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot/setup-frogbot/setup-frogbot-using-github-actions
Regarding the failing integration tests - The workflow was fixed and tested in a forked repository were the changes can be applied:
![Screenshot 2024-05-16 at 19 44 50](https://private-user-images.githubusercontent.com/81029514/331302833-24aee8fc-e24d-4ab5-b96a-3b488ce27f25.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE0OTQ0OTAsIm5iZiI6MTcyMTQ5NDE5MCwicGF0aCI6Ii84MTAyOTUxNC8zMzEzMDI4MzMtMjRhZWU4ZmMtZTI0ZC00YWI1LWI5NmEtM2I0ODhjZTI3ZjI1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIwVDE2NDk1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE0OWUwZTM4ZGRmNTE5YWYzMmJlOGFjMGNhNGJlNjdhZDE2NmJlZTFiMTc1NDA0NTE3ZTFmYzkxNTlmZWU1MmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.2E8-C36bPl2c3r7RfHUfREU_6zZzkoITADWOBWc5Zzg)
Regarding the new OIDC tests - They were executed in a forked repository as well and passed:
![Screenshot 2024-05-16 at 19 32 58](https://private-user-images.githubusercontent.com/81029514/331296891-0d040f52-6f8e-4109-98ce-a3683a882132.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE0OTQ0OTAsIm5iZiI6MTcyMTQ5NDE5MCwicGF0aCI6Ii84MTAyOTUxNC8zMzEyOTY4OTEtMGQwNDBmNTItNmY4ZS00MTA5LTk4Y2UtYTM2ODNhODgyMTMyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIwVDE2NDk1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZlOTAxNDA3ZDYzY2FhMWI3OTBhMmQ0NjcyNjVjMDMwMmI0MDY2ZGJmMDIzYmQ3M2M3Yjk0YzMzMGMxYTQ3YjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.fOppO1lRBga86Z8WOk-P_iuZD00ZgczHRj_DKUkGx1M)