Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing OIDC integration #696

Merged
merged 98 commits into from
May 19, 2024
Merged

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented May 16, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

Introducing OpenID-Connect authorization protocol!
This Feature allows the user to get an access token to be used by Frogbot without saving it as a secret in the repository.
For detailed explanation please refer to our documentation: https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot/setup-frogbot/setup-frogbot-using-github-actions

Regarding the failing integration tests - The workflow was fixed and tested in a forked repository were the changes can be applied:
Screenshot 2024-05-16 at 19 44 50

Regarding the new OIDC tests - They were executed in a forked repository as well and passed:
Screenshot 2024-05-16 at 19 32 58

action/lib/utils.js Outdated Show resolved Hide resolved
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label May 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 16, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label May 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 16, 2024
@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request labels May 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 16, 2024
@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request labels May 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 16, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label May 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 16, 2024
@eranturgeman eranturgeman merged commit ed6e024 into jfrog:dev May 19, 2024
25 of 30 checks passed
@eranturgeman eranturgeman changed the title introducing OIDC integration Introducing OIDC integration May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants