Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for a resource contention in a parallel tests execution #709

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Jun 13, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

As a part of our tests automation & improvement process we created a pipeline to execute Frogbot tests automatically and in parallel.
Two of those tests had contention over a mutual resource (analyzer manager) which was downloaded to the same place in both of them.
In order to fix it, we work in a temp JfrogHome for each of the tests so they will use two different instances of the analyzer manager.
The correction of the fix were verified in the pipeline:
Screenshot 2024-06-18 at 14 33 36

orz25 and others added 4 commits June 13, 2024 14:32
…cution-contention' into XRAY-75602-parallel-tests-execution-contention

# Conflicts:
#	go.mod
#	go.sum
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jun 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 18, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jun 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 18, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jun 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 18, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jun 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 18, 2024
@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Jun 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 18, 2024
@eranturgeman eranturgeman marked this pull request as ready for review June 18, 2024 11:07
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@eranturgeman eranturgeman changed the title Frogbot with eranturgeman local cli-security Fix for a resource contention in a parallel tests execution Jun 18, 2024
@eranturgeman eranturgeman removed the request for review from orz25 June 18, 2024 11:42
@eranturgeman eranturgeman merged commit 66f7c0d into jfrog:dev Jun 18, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants