Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run contextual analysis and secret detection in Docker scans #1035 #1052

Closed
wants to merge 13 commits into from
Closed

Run contextual analysis and secret detection in Docker scans #1035 #1052

wants to merge 13 commits into from

Conversation

guyshe-jfrog
Copy link
Contributor

@guyshe-jfrog guyshe-jfrog commented Nov 28, 2023 •
edited
Loading

Description

This PR adds to the docker scan command support for JFrog Advanced Security. Searching for applicable vulnerabilities and secrets.

Status

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Changes for #1035

Regarding tests - I am not sure how to add tests for this, if you could point me up to where? It looks like there is some coverage because I had to fix some tests.
Static analysis - I fixed gosec but the other looks like code unrelated to what I changd

I have read the CLA Document and I hereby sign the CLA

@yahavi yahavi changed the title Add JAS scanner support to docker scan command again #1035 Run contextual analysis and secret detection in Docker scans #1035 Nov 28, 2023
@yahavi yahavi added the new feature Automatically generated release notes label Nov 28, 2023
@gailazar300 gailazar300 mentioned this pull request Jan 3, 2024
Closed
4 tasks
This was referenced Jan 22, 2024
Closed
Merged
@eyalbe4
Copy link
Contributor

eyalbe4 commented Apr 21, 2024

Closing this PR, since these changes have already been implemented in the https://github.com/jfrog/jfrog-cli-security codebase.

@eyalbe4 eyalbe4 closed this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@guyshe-jfrog @eyalbe4 @yahavi @gailazar300