Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yarn install flags #1063

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Fix yarn install flags #1063

merged 5 commits into from
Dec 7, 2023

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Dec 7, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Fixed incorrect flags in 'yarn install' command during construction of a dependency tree

@eranturgeman eranturgeman changed the title fix in yarn install flags Fix yarn install flags Dec 7, 2023
@eranturgeman eranturgeman added the bug Something isn't working label Dec 7, 2023
@eranturgeman eranturgeman requested review from omerzi and attiasas and removed request for omerzi December 7, 2023 10:36
attiasas
attiasas reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you should include tests for those changes if you can.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@eranturgeman eranturgeman merged commit 7998769 into jfrog:dev Dec 7, 2023
8 checks passed
Or-Geva pushed a commit to Or-Geva/jfrog-cli-core that referenced this pull request Dec 11, 2023
@eranturgeman @Or-Geva
Fix yarn install flags (jfrog#1063)
abf9857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eranturgeman @attiasas