Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web login prompts #1178

Merged
merged 2 commits into from
May 1, 2024
Merged

Update web login prompts #1178

merged 2 commits into from
May 1, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Apr 30, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Revise the web login commands errors (jf login & jf c add with Web Login) to advise executing jf c add if the Artifactory version is below 7.64.0.
image

@yahavi yahavi added the improvement Automatically generated release notes label Apr 30, 2024
@yahavi yahavi requested review from eyalbe4 and RobiNino April 30, 2024 14:25
@yahavi yahavi self-assigned this Apr 30, 2024
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments to improve the user experience;

JFrog Platform URL:
-->
Enter your JFrog Platform URL:

Let's completely remove the question about the Artifactory Server proxy support. This is yet another adoption optical. Let's allow sending the proxy URL as a flag to the "jf c add" command only. Users who use the "jf login" shouldn't be bothered by it.

artifactory/utils/weblogin.go Outdated Show resolved Hide resolved
@yahavi yahavi changed the title Update web login message Update web login prompts May 1, 2024
@yahavi yahavi merged commit cca5055 into jfrog:dev May 1, 2024
6 of 7 checks passed
@yahavi yahavi deleted the update-weblogin-command branch May 1, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants