Command Summaries #1179
Merged
Command Summaries #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve UI for scan command (jfrog#706) * Upgrade go version in go.mod to 1.20 (jfrog#732) * Fix lint issues found (jfrog#733) * Config transfer - ensure target not older than source (jfrog#721) * Update tests environment - nuget and dotnet to version 6 (jfrog#734) * Flatten audit graph (jfrog#736) * Use gradle-dep-tree with Audit (jfrog#719) --------- Co-authored-by: Sara Omari <114062096+sarao1310@users.noreply.github.com> Co-authored-by: Eyal Ben Moshe <eyalbenmoshe@jfrog.com> Co-authored-by: Michael Sverdlov <sverdlov93@gmail.com> Co-authored-by: Yahav Itzhak <yahavi@users.noreply.github.com>
# Conflicts: # .github/workflows/analysis.yml # go.mod # go.sum # xray/audit/java/gradle.go # xray/commands/audit/generic/auditmanager.go
4 tasks
yahavi
requested changes
May 20, 2024
There was a problem hiding this comment.
Well done @EyalDelarea!
Please consider my inline comments.
eyalbe4
requested changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command Summaries
Allows to record data of CLI commands results to the filesystem, and create markdown files based on the files.
How to implement
In order to use the command summaries feature you'll have to implement the function's interface
Which will take a slice of full file paths and will need to generate a markdown for it.
How does it work?
Each time you have a command results you'd like to save, you create a markdown.
This action will save the current result to the file system, and will be reposbile for creating
a markdown string, based on ALL the files exsiting inside the file system.
The filesystem will look like this:
