Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing description on Xray help section subcommands #1181

Merged
merged 2 commits into from
May 5, 2024
Merged

Add missing description on Xray help section subcommands #1181

merged 2 commits into from
May 5, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented May 5, 2024 •
edited

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Fix not showing description for subcommands:

image

To:

image

@attiasas attiasas added the bug Something isn't working label May 5, 2024
@attiasas attiasas requested a review from sverdlov93 May 5, 2024 15:27
@sverdlov93 sverdlov93 changed the title Add description as usage for subcommands Add missing description on Xray subcommands May 5, 2024
@sverdlov93 sverdlov93 changed the title Add missing description on Xray subcommands Add missing description on Xray help section subcommands May 5, 2024
sverdlov93
sverdlov93 approved these changes May 5, 2024
View reviewed changes
Copy link
Contributor

@sverdlov93 sverdlov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👑

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.

@eyalbe4 eyalbe4 merged commit 7173b50 into jfrog:dev May 5, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

@sverdlov93 sverdlov93 sverdlov93 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@attiasas @eyalbe4 @sverdlov93