Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate defered callback funcs are not nil before running #1184

Merged
merged 6 commits into from
May 9, 2024
Merged

Validate defered callback funcs are not nil before running #1184

merged 6 commits into from
May 9, 2024

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented May 8, 2024 •
edited

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

should fix #1183

@sverdlov93
Improve help section
573d058 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Improve help section
db5d3a1 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into updep
fd6f2a6
@sverdlov93 sverdlov93 requested a review from yahavi May 8, 2024 14:09
@sverdlov93 sverdlov93 added the bug Something isn't working label May 8, 2024
@sverdlov93 sverdlov93 changed the title Validate Dotnet Command callbackFunc not nil before running Dotnet command - validate callback func is not nil May 8, 2024
@sverdlov93 sverdlov93 mentioned this pull request May 8, 2024
Closed
@sverdlov93 sverdlov93 requested a review from eyalbe4 May 8, 2024 14:11
@sverdlov93
Improve help section
c6d9311 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Improve help section
1e87fe0 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 changed the title Dotnet command - validate callback func is not nil Validate defered callback funcs are not nil before running May 8, 2024
@sverdlov93
Improve help section
957cb39 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 merged commit 5433b78 into jfrog:dev May 9, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sverdlov93 @yahavi