Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer - remove chunk upload checksum deploy support #475

Merged
merged 4 commits into from
Aug 2, 2022

Conversation

RobiNino
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@eyalbe4 eyalbe4 added the improvement Automatically generated release notes label Aug 1, 2022
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Please consider my comments.

utils/transfer/utils.go Outdated Show resolved Hide resolved
artifactory/commands/transferfiles/transfer_test.go Outdated Show resolved Hide resolved
artifactory/commands/transferfiles/transfer_test.go Outdated Show resolved Hide resolved
artifactory/commands/transferfiles/transfer_test.go Outdated Show resolved Hide resolved
artifactory/commands/transferfiles/transfer_test.go Outdated Show resolved Hide resolved
artifactory/commands/transferfiles/srcpluginservice.go Outdated Show resolved Hide resolved
…ansfer-remove-checksum-deploy

# Conflicts:
#	artifactory/commands/transferconfig/transferconfig_test.go
#	artifactory/commands/transferfiles/srcpluginservice.go
#	artifactory/commands/transferfiles/transfer_test.go
#	artifactory/commands/transferfiles/utils.go
@RobiNino RobiNino merged commit 4f333ae into jfrog:dev Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants