Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running jas scanners in parallel #33

Merged
merged 70 commits into from
Jun 18, 2024
Merged

Conversation

orz25
Copy link
Contributor

@orz25 orz25 commented Mar 3, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

In this PR we worked on running all scans (sca, jas) in parallel, using gofrog parallel package .

The part of building the dependency tree is not running in parallel, the command will first build the dependency tree to all modules, and then scan them

We added a new flag for the audit command, "threads", allowing the user to input the number of parallel tasks that can be created during the run.
The progress bar changed - it will show 2 statuses: Calculating {tech} dependencies, Scanning for issues.

PR for needed changes is Frogbot - jfrog/frogbot#692
PR for updating audit command document - jfrog/documentation#134

@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Mar 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 21, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Mar 31, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 31, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Apr 3, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 3, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Apr 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 4, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Apr 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 4, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Apr 7, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 7, 2024
@attiasas attiasas added the improvement Automatically generated release notes label Apr 8, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 16, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Jun 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 18, 2024
@orz25 orz25 merged commit bb2f45c into jfrog:dev Jun 18, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants