Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for executing commands with progress bar #1516

Merged
merged 9 commits into from
May 2, 2022
Merged

Add tests for executing commands with progress bar #1516

merged 9 commits into from
May 2, 2022

Conversation

talarian1
Copy link
Contributor

@talarian1 talarian1 commented Apr 17, 2022 •
edited

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Fixes #1341.
Depending on core, client

@github-actions
Copy link
Contributor

What is Frogbot?

@talarian1 talarian1 added safe to test Approve running integration tests on a pull request 🐸 frogbot scan labels Apr 17, 2022
@github-actions
Copy link
Contributor

What is Frogbot?

@talarian1 talarian1 marked this pull request as ready for review April 18, 2022 11:38
@talarian1 talarian1 requested a review from eyalbe4 April 18, 2022 11:39
@talarian1 talarian1 added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Apr 18, 2022
@Or-Geva Or-Geva added the ignore for release Automatically generated release notes label Apr 27, 2022
eyalbe4
eyalbe4 requested changes Apr 28, 2022
View reviewed changes
utils/progressbar/progressbar.go Outdated Show resolved Hide resolved
utils/tests/utils.go Outdated Show resolved Hide resolved
plugins_test.go Outdated Show resolved Hide resolved
plugins_test.go Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

What is Frogbot?

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

What is Frogbot?

@talarian1 talarian1 merged commit f51c8af into jfrog:dev May 2, 2022
@eyalbe4 eyalbe4 added improvement Automatically generated release notes and removed ignore for release Automatically generated release notes labels May 8, 2022
@talarian1 talarian1 deleted the add-progress-tests branch May 24, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes safe to test Approve running integration tests on a pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@talarian1 @eyalbe4 @Or-Geva