Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unarchive inspection #1899

Merged
merged 4 commits into from
Apr 23, 2023
Merged

Improve unarchive inspection #1899

merged 4 commits into from
Apr 23, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Apr 9, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Depends on:

Improve explode algorithm and add the --bypass-archive-inspection option to jf rt dl.

@yahavi yahavi added the improvement Automatically generated release notes label Apr 9, 2023
@yahavi yahavi requested a review from eyalbe4 April 9, 2023 13:27
@yahavi yahavi self-assigned this Apr 9, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Apr 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 9, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Apr 17, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 17, 2023
eyalbe4
eyalbe4 requested changes Apr 17, 2023
View reviewed changes
schema/filespec-schema.json Outdated Show resolved Hide resolved
schema/filespec-schema.json Outdated Show resolved Hide resolved
utils/cliutils/commandsflags.go Outdated Show resolved Hide resolved
eyalbe4
eyalbe4 requested changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also ensure that tests are green before merging.

@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Apr 18, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 18, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Apr 18, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 18, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Apr 23, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 23, 2023
@yahavi yahavi merged commit ed8ce92 into jfrog:dev Apr 23, 2023
9 of 10 checks passed
@yahavi yahavi deleted the unarchiver branch April 23, 2023 07:03
@p-linnane p-linnane mentioned this pull request May 3, 2023
Merged
@yahavi yahavi mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees

@yahavi yahavi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yahavi @eyalbe4