Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer config - allow providing the src work dir #1923

Merged
merged 2 commits into from Jun 1, 2023
Merged

Transfer config - allow providing the src work dir #1923

merged 2 commits into from Jun 1, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Apr 30, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Depends on jfrog/jfrog-cli-core#763
Fix jfrog/jfrog-cli-core#694

Instead of --working-dir, introduce --source-working-dir and --target-working-dir for the jf rt transfer-config command.

@yahavi yahavi added the improvement Automatically generated release notes label Apr 30, 2023
@yahavi yahavi requested a review from eyalbe4 April 30, 2023 09:43
@yahavi yahavi self-assigned this Apr 30, 2023
@yahavi yahavi temporarily deployed to frogbot April 30, 2023 09:43 — with GitHub Actions Inactive
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Apr 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 30, 2023
@github-actions
Copy link
Contributor

What is Frogbot?

@yahavi yahavi linked an issue Apr 30, 2023 that may be closed by this pull request
improvement for transfer-config : specify a target path for the generated export jfrog/jfrog-cli-core#694
Open
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jun 1, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 1, 2023
@yahavi yahavi merged commit c79ab49 into jfrog:dev Jun 1, 2023
58 of 59 checks passed
@yahavi yahavi deleted the src-work branch June 1, 2023 07:10
@chenrui333 chenrui333 mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Assignees

@yahavi yahavi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improvement for transfer-config : specify a target path for the generated export
2 participants
@yahavi @eyalbe4