Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defer wrong inner function calls #1937

Merged
merged 3 commits into from
May 15, 2023
Merged

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented May 7, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

defer func1( func2() ) is wrong here. Should be wrapped with:

defer func() {
	func1( func2() )
}()

@sverdlov93 sverdlov93 requested review from yahavi and eyalbe4 May 7, 2023 18:05
@sverdlov93 sverdlov93 added the ignore for release Automatically generated release notes label May 8, 2023
@sverdlov93 sverdlov93 merged commit d8a53bf into jfrog:dev May 15, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants