CVE applicability indication for jf audit
#1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
orto17
commented
May 8, 2023
orto17
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
eyalbe4
changed the title
jf audit
eyalbe4
added
new feature
github-actions
bot
removed
the
safe to test
eyalbe4
requested changes
May 14, 2023
There was a problem hiding this comment.
Go ahead and add the new functionality to the JFrog CLI documentation. The source files for the documentation and managed under the "documentation" directory.
In addition to the description for the new Contextual Analysis feature, let's also explain how to subscribe to the new Advanced Security package.
I also suggest adding a few images to showcase the new functionality as part of the "jf audit" command.
Let's also ensure that all the tests are passing.
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
approved these changes
May 16, 2023
There was a problem hiding this comment.
@orto17,
I have some comments for the documentation, but I suggest we merge this PR, and then I'll create a follow-up PR to improve the documentation.
Please go ahead and resolve the conflicts, and we'll merge once the tests are grenn.
# Conflicts: # go.mod # go.sum
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
talarian1
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.