Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal cli code #2503

Merged
merged 20 commits into from Mar 28, 2024
Merged

Internal cli code #2503

merged 20 commits into from Mar 28, 2024

Conversation

sverdlov93
Copy link
Contributor

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

sverdlov93 and others added 15 commits July 26, 2021 14:25
@sverdlov93
Add sverdlov93_jfrog_cli_pipeline
9ca133f
@sverdlov93
michael test commit
9133730
@sverdlov93
Merge remote-tracking branch 'origin/dev' into dev
dc32a3f
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into dev
693aee3
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into dev
ca47345 
� Conflicts:
�	pipelines.yml
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into dev
63a8ffc
@sverdlov93
add test for summary csv
342cd73 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93
add test for summary csv
69ed23f 
Signed-off-by: sverdlov93 <sverdlov93@gmail.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into simple-…
9228241 
…defer

# Conflicts:
#	buildtools/cli.go
#	go.mod
#	go.sum
@sverdlov93
simplify defer closers
f2bf7b2 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
simplify defer closers
f76dfa2 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
simplify defer closers
1dbd80a 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into simple-…
110b90d 
…defer

# Conflicts:
#	go.sum
@sverdlov93
update deps
3ac4543 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into simple-…
5e6aced 
…defer

# Conflicts:
#	go.mod
#	go.sum
@sverdlov93
update deps
03a1c71 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 requested a review from eyalbe4 March 27, 2024 17:09
@sverdlov93
update deps
0d544c2 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the ignore for release Automatically generated release notes label Mar 28, 2024
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Mar 28, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 28, 2024
@sverdlov93
update deps
aced8a8 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
eyalbe4
eyalbe4 requested changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use this opprtunity to remove the below commented out code, and any code that is referenced by this code.

general/ai/cli.go Show resolved Hide resolved
general/ai/cli.go Outdated Show resolved Hide resolved
general/ai/cli.go Outdated Show resolved Hide resolved
general/ai/cli.go Outdated Show resolved Hide resolved
general/ai/cli.go Outdated Show resolved Hide resolved
general/ai/cli.go Outdated Show resolved Hide resolved
general/ai/cli.go Outdated Show resolved Hide resolved
general/ai/cli.go Outdated Show resolved Hide resolved
general/ai/cli.go Outdated Show resolved Hide resolved
general/ai/cli.go Outdated Show resolved Hide resolved
@sverdlov93
update deps
3597be6 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
update deps
03c6d3b 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Mar 28, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 28, 2024
@sverdlov93 sverdlov93 merged commit 4a0a9a4 into jfrog:dev Mar 28, 2024
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sverdlov93 @eyalbe4