Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve help sections, add details to command descriptions and hide redundant commands #2525

Merged
merged 22 commits into from
May 6, 2024
Merged

Improve help sections, add details to command descriptions and hide redundant commands #2525

merged 22 commits into from
May 6, 2024

Conversation

sverdlov93
Copy link
Contributor

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

@sverdlov93
update deps
e11f845 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
update deps
6d5f71e 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Improve help section
b23b22a 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into remove-…
c546ea2 
…inv-flow
@sverdlov93
Improve help section
25a1552 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 changed the title Rephrase help sections, add details to command descriptions Improve help sections, add details to command descriptions Apr 18, 2024
@sverdlov93
Improve help section
809d0ce 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 requested a review from eyalbe4 April 18, 2024 12:52
@sverdlov93
Improve help section
23eebd3 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Apr 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 18, 2024
@sverdlov93
Improve help section
7e8db10 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Improve help section
bec13e7 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 requested a review from yahavi April 21, 2024 08:16
@sverdlov93
Improve help section
83b66ad 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 changed the title Improve help sections, add details to command descriptions Improve help sections, add details to command descriptions and hide redundant commands Apr 21, 2024
@sverdlov93
Improve help section
3446990 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Improve help section
30326c0 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Improve help section
6918d4c 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Apr 30, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 30, 2024
@sverdlov93
Improve help section
cba659f 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into remove-…
ba5ea67 
…inv-flow

# Conflicts:
#	go.mod
#	go.sum
@sverdlov93
Improve help section
07752ed 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge remote-tracking branch 'sverdlov93/remove-inv-flow' into remove…
a1a87a7 
…-inv-flow
@sverdlov93
Improve help section
fc2cbf5 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
yahavi
yahavi requested changes May 5, 2024
View reviewed changes
docs/artifactory/move/help.go Outdated Show resolved Hide resolved
docs/artifactory/groupaddusers/help.go Outdated Show resolved Hide resolved
docs/artifactory/usersdelete/help.go Outdated Show resolved Hide resolved
docs/artifactory/deleteprops/help.go Show resolved Hide resolved
docs/artifactory/usersdelete/help.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
utils/cliutils/commandsflags.go Outdated Show resolved Hide resolved
utils/cliutils/commandsflags.go Show resolved Hide resolved
@sverdlov93
Improve help section
302ee2c 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Improve help section
88c8581 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 merged commit b17e679 into jfrog:dev May 6, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sverdlov93 @yahavi