Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release bundle creation with project #2536

Merged
merged 6 commits into from
May 6, 2024
Merged

Fix release bundle creation with project #2536

merged 6 commits into from
May 6, 2024

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented May 1, 2024 •
edited

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Following #2535
Tests depend on jfrog/jfrog-client-go#948

@RobiNino RobiNino added bug Something isn't working safe to test Approve running integration tests on a pull request labels May 1, 2024
@RobiNino RobiNino requested review from eyalbe4 and yahavi May 1, 2024 08:01
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 1, 2024
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label May 5, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 5, 2024
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label May 5, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 5, 2024
yahavi
yahavi requested changes May 5, 2024
View reviewed changes
utils/cliutils/utils.go Outdated Show resolved Hide resolved
lifecycle/cli.go Show resolved Hide resolved
@RobiNino RobiNino merged commit 3f830ed into jfrog:dev May 6, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RobiNino @yahavi