Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go to 1.22.x #2540

Merged
merged 9 commits into from
May 19, 2024
Merged

Update go to 1.22.x #2540

merged 9 commits into from
May 19, 2024

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented May 6, 2024

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Update JFrog CLI to Go 1.22.x

Specific go version for release : 1.22.3
Depends on for release:
jfrog/jfrog-ecosystem-integration-env#46

The update should be a top down approach, first update the CLI and then the rest of the components.
As the CLI will be able to consume lower versions of Go, but not the other way around.

@EyalDelarea EyalDelarea added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels May 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 6, 2024
@EyalDelarea EyalDelarea marked this pull request as ready for review May 6, 2024 13:40
Jenkinsfile Outdated Show resolved Hide resolved
@sverdlov93
Copy link
Contributor

sverdlov93 commented May 6, 2024

also need to update here and release it - https://github.com/jfrog/jfrog-ecosystem-integration-env

@EyalDelarea
Copy link
Contributor Author

@sverdlov93
Let me know what you think, after we will merge i'll update the jfrog/jfrog-ecosystem-integration-env#46 PR before next CLI release.

Copy link
Contributor

@sverdlov93 sverdlov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@EyalDelarea EyalDelarea merged commit 8b18d92 into jfrog:dev May 19, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants